Skip to content

Fix leak of resolved address list in snmp_session_init() #22340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iliaal wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+17 −0
Open

Fix leak of resolved address list in snmp_session_init() #22340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ext/snmp/snmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,6 +910,7 @@ static bool netsnmp_session_init(php_snmp_session **session_p, int version, zend

if (strlen(session->peername) == 0) {
php_error_docref(NULL, E_WARNING, "Unknown failure while resolving '%s'", ZSTR_VAL(hostname));
php_network_freeaddresses(psal);
return false;
}
/* XXX FIXME
Expand Down
16 changes: 16 additions & 0 deletions ext/snmp/tests/snmp_resolve_fail_leak.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
--TEST--
snmp: resolved address list is freed when peername resolution drains empty
--EXTENSIONS--
snmp
--FILE--
<?php
// Bracketed (IPv6) syntax over an IPv4-only literal forces IPv6 resolution,
// which drains to no usable address, hitting the "Unknown failure while
// resolving" path. That path must free the address list from
// php_network_getaddresses() (it previously leaked it). No SNMP agent needed:
// the function fails at peername resolution before any query is sent.
var_dump(snmpget("[127.0.0.1]", "public", ".1.3.6.1.2.1.1.1.0"));
?>
--EXPECTF--
Warning: snmpget(): Unknown failure while resolving '[127.0.0.1]' in %s on line %d
bool(false)
Loading