Fix leak of resolved address list in snmp_session_init()#22340
Open
iliaal wants to merge 1 commit into
Open
Conversation
When php_network_getaddresses() succeeds but none of the resolved addresses yield a usable peer name (for example bracketed IPv6 syntax over an IPv4-only host), snmp_session_init() returned without calling php_network_freeaddresses(), leaking the address list on every such call. Free it on that error path as the success path already does. Closes phpGH-22340
iliaal
force-pushed
the
fix-snmp-resolver-leak
branch
from
23f2a25 to
a33d77f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When php_network_getaddresses() succeeds but no resolved address yields a usable peer name (for example bracketed IPv6 syntax over an IPv4-only host), snmp_session_init() returned without php_network_freeaddresses(), leaking the address list on every such call. Free it on that error path, matching the success path and the convention in main/network.c.