Skip to content

Rust: Remove some redundant imports / casts #22056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoffw0 merged 3 commits into from
Jun 25, 2026
Merged

Rust: Remove some redundant imports / casts #22056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9a132d
Rust: Remove redundant cast.
geoffw0 Apr 29, 2026
20b4cbe
Rust: Remove pointless imports of codeql.util.Unit.
geoffw0 Jun 25, 2026
ca09327
Rust: Remove more pointless imports.
geoffw0 Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion rust/ql/lib/codeql/rust/security/LogInjectionExtensions.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ private import codeql.rust.dataflow.DataFlow
private import codeql.rust.dataflow.FlowBarrier
private import codeql.rust.dataflow.FlowSink
private import codeql.rust.Concepts
private import codeql.util.Unit
private import codeql.rust.security.Barriers as Barriers

/**
Expand Down
1 change: 0 additions & 1 deletion rust/ql/lib/codeql/rust/security/SensitiveData.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ private class SensitiveVariableAccess extends SensitiveData {
HeuristicNames::nameIndicatesSensitiveData(this.asExpr()
.(VariableAccess)
.getVariable()
.(Variable)
.getText(), classification)
}

Expand Down
1 change: 0 additions & 1 deletion rust/ql/lib/codeql/rust/security/SqlInjectionExtensions.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ private import codeql.rust.dataflow.DataFlow
private import codeql.rust.dataflow.FlowBarrier
private import codeql.rust.dataflow.FlowSink
private import codeql.rust.Concepts
private import codeql.util.Unit
private import codeql.rust.security.Barriers as Barriers

/**
Expand Down
4 changes: 0 additions & 4 deletions rust/ql/lib/codeql/rust/security/TaintedPathExtensions.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
/** Provides classes and predicates to reason about path injection vulnerabilities. */

import rust
private import codeql.rust.controlflow.BasicBlocks
private import codeql.rust.controlflow.ControlFlowGraph
private import codeql.rust.dataflow.DataFlow
private import codeql.rust.dataflow.TaintTracking
private import codeql.rust.Concepts
private import codeql.rust.dataflow.internal.DataFlowImpl
private import codeql.rust.controlflow.ControlFlowGraph as Cfg

/**
* Provides default sources, sinks and barriers for detecting path injection
Expand Down
1 change: 0 additions & 1 deletion rust/ql/lib/codeql/rust/security/XssExtensions.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ private import codeql.rust.dataflow.DataFlow
private import codeql.rust.dataflow.FlowBarrier
private import codeql.rust.dataflow.FlowSink
private import codeql.rust.Concepts
private import codeql.util.Unit
private import codeql.rust.security.Barriers as Barriers

/**
Expand Down
Loading