Rust: Remove some redundant imports / casts#22056
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the Rust security QL libraries by removing unused imports and a redundant cast, reducing noise and keeping the libraries easier to maintain.
Changes:
- Removed unused
codeql.util.Unitimports from several Rust security extension libraries. - Removed unused control-flow/taint-tracking imports from
TaintedPathExtensions.qll. - Dropped a redundant
.(Variable)cast inSensitiveData.qll.
Show a summary per file
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/security/XssExtensions.qll | Removes an unused codeql.util.Unit import. |
| rust/ql/lib/codeql/rust/security/TaintedPathExtensions.qll | Removes unused control-flow/taint-tracking related imports. |
| rust/ql/lib/codeql/rust/security/SqlInjectionExtensions.qll | Removes an unused codeql.util.Unit import. |
| rust/ql/lib/codeql/rust/security/SensitiveData.qll | Removes a redundant .(Variable) cast in a sensitive-name heuristic. |
| rust/ql/lib/codeql/rust/security/LogInjectionExtensions.qll | Removes an unused codeql.util.Unit import. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 0
hvitved
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some redundant imports / casts.
There's no particular direction here, you're looking at leftovers after a (not especially successful) experiment at getting AI to improve code quality.