chore(release): 0.18.1#556
Merged
Merged
Conversation
jkmassel
requested review from
crazytonyli and
dcalhoun
and removed request for
crazytonyli
July 18, 2026 23:48
XCFramework BuildThis PR's XCFramework is available for testing. Add the following to your .package(url: "https://github.com/wordpress-mobile/GutenbergKit", branch: "pr-build/556")Built from fb2e06f |
crazytonyli
approved these changes
Jul 19, 2026
Contributor
|
I'll merge this PR and release the version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Bumps
0.18.0→0.18.1to cut a patch release that ships #551 — version bump only, no other changes.Why?
v0.18.0predates #551, which stampsCFBundleShortVersionStringandMinimumOSVersioninto theGutenbergKitResources.frameworkInfo.plist. Without those keys, apps embedding GutenbergKit fail to upload to TestFlight (altool90057 / 90360). The fix is ontrunkbut unreleased, so no SPM consumer can pin a tag that contains it. This is the bump that lets us tagv0.18.1.How?
npm --no-git-tag-version version patch+npm run generate-version— four files, version fields only:package.json/package-lock.json→0.18.1ios/Sources/GutenbergKit/Sources/GutenbergKitVersion.swift→version = "0.18.1"— compiled into theGutenbergKitlibrary from source (even in.releasemode), so it has to be committed at the tagged commitandroid/.../GutenbergKitVersion.kt→VERSION = "0.18.1"No rebuilt web bundle, unlike the
0.18.0bump. The CIBuild XCFrameworkstep downloads a freshly-builtdist/andcopy-dist-iosoverwrites the committedGutenberg/bundle before packaging — "ship the just-built dist rather than whatever was committed at HEAD" (Makefile) — andbuild_xcframework.shstamps the framework version frompackage.json. So the committed bundle isn't load-bearing for the tag, and it's byte-identical tov0.18.0regardless (#551 only touchedbuild_xcframework.sh). Trunk staysresourcesMode = .local; its committed bundle keeps reporting0.18.0in JS error metadata until the next full build — cosmetic, trunk-only, invisible to tag consumers.Testing Instructions
Publish is the manual Buildkite flow (
docs/releases.md), pinned to this PR's merge commit:trunkautomattic/gutenbergkit→ Branchtrunk, Commit = merge SHA,NEW_VERSION=v0.18.1Validate Swift releasepasses (no pre-existing tag/Release)v0.18.1tag + GitHub Release published, XCFramework on CDNv0.18.1uploads to TestFlight cleanly (verifies the 90057/90360 regression is gone)Related: #551