NFC-171 Validate signing cert chain, formats and configured origin#121
NFC-171 Validate signing cert chain, formats and configured origin#121SanderKondratjevNortal wants to merge 2 commits into
Conversation
Signed-off-by: Sander Kondratjev <sander.kondratjev@nortal.com>
|
|
||
| var challenge = nonceGenerator.generateAndStoreNonce(); | ||
|
|
||
| String loginUri = ServletUriComponentsBuilder.fromCurrentContextPath() |
There was a problem hiding this comment.
Without .fromCurrentContextPath() deploying the example under a non-root context path will no longer work. If this is intended, it should be documented in README.
There was a problem hiding this comment.
Will be added to readme in different task: The mobile authentication and signing example uses the configured web-eid-auth-token.validation.local-origin value when constructing mobile callback URIs. The example assumes that the application is deployed under the root context path (/). If deploying under a non-root context path, adjust the callback URI construction accordingly.
|
|
||
| @Override | ||
| public boolean supports(String format) { | ||
| return format != null && format.startsWith(getSupportedFormatPrefix()); |
There was a problem hiding this comment.
As documented in README.md, minor versions must be backward-compatible within the major version, this will reject future compatible web-eid:1.x tokens.
There was a problem hiding this comment.
I see, updated the code and tests.
Signed-off-by: Sander Kondratjev <sander.kondratjev@nortal.com>
|
2 participants
Signed-off-by: Sander Kondratjev sander.kondratjev@nortal.com