Skip to content

Fix mpi bug#217

Merged
awvwgk merged 3 commits into
wavefunction91:skalafrom
JensWehner:fix_mpi_bug
Jul 17, 2026
Merged

Fix mpi bug#217
awvwgk merged 3 commits into
wavefunction91:skalafrom
JensWehner:fix_mpi_bug

Conversation

@JensWehner

@JensWehner JensWehner commented Jul 16, 2026

Copy link
Copy Markdown

Fix for cp2k/cp2k#5537

as described there, the problem was using the global communicator, because cp2k actually passes a subgroup in and then indices derived from the global one are wrong. Exactly what they described in the issue.

Added a test and compiled cp2k with it and then the error seems to be gone.

@tvogels tvogels left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@awvwgk awvwgk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@awvwgk
awvwgk merged commit ea0f1fc into wavefunction91:skala Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants