Use AllNonDistinct in assert_arrays_eq and implement it for variant types#8546
Open
robert3005 wants to merge 1 commit into
Open
Use AllNonDistinct in assert_arrays_eq and implement it for variant types#8546robert3005 wants to merge 1 commit into
robert3005 wants to merge 1 commit into
Conversation
…ypes assert_arrays_eq_impl detects equality via all_non_distinct (with a lazy find_mismatched_indices only to build the failure message). Adds the Canonical::Variant arm (compare logical variant scalars), a ParquetVariant aggregate kernel that compares typed_value/value children directly, and fixes check_primitive_identical to use NativePType::is_eq (bitwise float equality). Stacked on the assert_arrays_eq (ExecutionCtx threading) branch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
force-pushed
the
assert_arrays_eq_allnondistinct
branch
from
28495bc to
e89702f
Compare
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
168.9 µs | 205.6 µs | -17.86% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
258.9 µs | 224.2 µs | +15.47% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
244.4 ns | 215.3 ns | +13.55% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
306 µs | 271.1 µs | +12.87% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
304.7 ns | 275.6 ns | +10.58% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing assert_arrays_eq_allnondistinct (e89702f) with develop (5a764e6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AllNonDistinct is exactly the semantics we want, it should be faster and in case
of failure we run the slow method to produce precise error message