Reduce vortex-fastlanes debug symbols size by introducing debug-only path#8502
Draft
AdamGS wants to merge 2 commits into
Draft
Reduce vortex-fastlanes debug symbols size by introducing debug-only path#8502AdamGS wants to merge 2 commits into
AdamGS wants to merge 2 commits into
Conversation
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | decompress_rd[f64, (10000, 0.1)] |
109 µs | 135.5 µs | -19.55% |
| ❌ | Simulation | decompress_rd[f64, (10000, 0.01)] |
108.7 µs | 135.1 µs | -19.54% |
| ❌ | Simulation | decompress_rd[f64, (10000, 0.0)] |
108.7 µs | 135.1 µs | -19.54% |
| ❌ | Simulation | decompress_rd[f32, (10000, 0.1)] |
78.1 µs | 86.8 µs | -10.04% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
206.8 µs | 170.2 µs | +21.46% |
| ⚡ | Simulation | decompress_rd[f64, (100000, 0.0)] |
978.9 µs | 843.2 µs | +16.1% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
307.1 µs | 272.8 µs | +12.59% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/reduce-debug-symbols-fastlanes (31b9d58) with develop (3a7b9a0)
532f345 to
aefa6b8
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
aefa6b8 to
8b3b046
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vortex-fastlanesis currently a pretty big crate, due to its underlying structure/generics.When running
cargo clean; cargo build -p vortex-fastlanesCurrently on `develop:
We currently disable debug symbols for it to improve our development experience, but underlying crates can't enjoy that without explicitly adding the same or similar configuration.
With this branch, the build takes 30s and generates a 60MB rlib, with no performance impact for release builds.