fix(global): ignore project node version for global pm#1866
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56a86e765a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Pushed a targeted clippy fix for the unused current_dir import in crates/vite_global_cli/src/commands/global/install.rs. git diff --check passes locally; cargo fmt could not run because the local nightly rustfmt binary is missing its librustc_driver dylib. |
|
Follow-up pushed: updated the failing global snap fixtures from the latest CI diffs. The pnpm project-node fixture now uses Node 22.13.0 so latest pnpm can still exercise the intended inheritance behavior, and the global-install nodeVersion snapshots match the current CI runtime. Local checks: |
|
Pushed another CI fix in |
|
Addressed the Codex corepack fallback finding in Local validation:
I attempted |
Summary
.node-versionandpackage.jsonengine fields.vp install -g/vp add -g, global update node-mismatch checks, and global outdated registry lookups.--node,VP_NODE_VERSION, session file, user default, and LTS fallback behavior intact.Closes #1621
Test Plan
git diff --checkRUSTUP_TOOLCHAIN=stable rustfmt --edition 2024 --check crates/vite_global_cli/src/cli.rs crates/vite_global_cli/src/commands/env/config.rs crates/vite_global_cli/src/commands/global/install.rs crates/vite_global_cli/src/commands/global/mod.rsAttempted but blocked locally:
cargo fmt --checkandcargo test -p vite-global-cli test_resolve_global_package_version -- --nocapturewere blocked because the repo nightly toolchain (nightly-2026-06-10) was partially installed andrustupstalled while downloading the required components.RUSTUP_TOOLCHAIN=stablereached dependency resolution but failed because this workspace needs nightly-Z bindepsforfspyfromvite-task.