Skip to content

build: use "selinux" instead of "feat_selinux" feature name#12431

Open
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:selinux
Open

build: use "selinux" instead of "feat_selinux" feature name#12431
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:selinux

Conversation

@xtqqczze

@xtqqczze xtqqczze commented May 22, 2026

Copy link
Copy Markdown
Contributor

Do not specify feat_selinux in individual crates; it is now only defined at the workspace level.

cc: @cakebaker

@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.

@xtqqczze xtqqczze marked this pull request as ready for review May 22, 2026 02:13
@oech3

oech3 commented May 22, 2026

Copy link
Copy Markdown
Contributor

coreutils/README.md

Lines 123 to 126 in bd908f0

To build SELinux-specific features, including `chcon` and `runcon`, ensure that `libselinux`
and `libclang` are installed on your system. Then, run the following command:
```
cargo build --release --features unix,feat_selinux

@oech3

oech3 commented May 22, 2026

Copy link
Copy Markdown
Contributor

why test only?

@xtqqczze xtqqczze changed the title tests: use "selinux" instead of "feat_selinux" feature name build: use "selinux" instead of "feat_selinux" feature name May 22, 2026
@xtqqczze

Copy link
Copy Markdown
Contributor Author

@sylvestre could you please review?

@codspeed-hq

codspeed-hq Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 7.8%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 338 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation complex_relative_date 147.6 µs 136.9 µs +7.8%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:selinux (7f37c3c) with main (65957d9)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@xtqqczze xtqqczze force-pushed the selinux branch 3 times, most recently from 6ed1b72 to c9cb38d Compare July 15, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants