fix(docker): tolerate unavailable IPv6 loopback#2081
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2078.
Make Redis's IPv6 loopback bind optional while retaining mandatory IPv4 loopback binding. Redis therefore starts on IPv4-only hosts instead of aborting when
::1is unavailable, while continuing to listen on IPv6 loopback where supported.List of files changed and why
deploy/docker/supervisord.conf- Prefix the IPv6 loopback address with Redis's optional-address marker.deploy/docker/tests/test_security_container_posture.py- Require the IPv4 loopback plus optional IPv6 bind form in the container posture test.How Has This Been Tested?
PYTHONPATH=. pytest -q deploy/docker/tests/test_security_container_posture.py— 19 passed.PYTHONPATH=. pytest -q deploy/docker/tests/test_security_*.py— 316 passed, 1 expected xfail.black --check --target-version py312 --line-ranges 77-84 deploy/docker/tests/test_security_container_posture.py— passed.git diff --check— passed.Checklist: