refactor(proto): move protos to top-level api/ tree by domain/service#258
Open
behinddwalls wants to merge 1 commit into
Open
refactor(proto): move protos to top-level api/ tree by domain/service#258behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
Relocate each service's proto/ and protopb/ dirs under api/{domain}/{service}/,
updating go_package, Bazel importpaths, gazelle resolve hints, consumer deps,
and all Go imports to .../api/{domain}/{service}/protopb.
Generalize the tool/proto codegen rule and the `make proto` copy loop to
support multiple .proto files per service package, so messagequeue payload
contracts can later be added alongside each service's RPC contract under the
same api/{domain}/{service}/proto dir.
Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on top of
refactor(#257). Moves all proto wire contracts into a single top-levelapi/tree organized bydomain/service, and lays the groundwork for upcoming messagequeue payload contracts.proto/andprotopb/dirs toapi/{domain}/{service}/(history-preserving renames). New importpath:github.com/uber/submitqueue/api/{domain}/{service}/protopb.go_package, all Bazel importpaths, rootgazelle:resolvehints, consumerdeps, and all Go imports.tool/protocodegen rule (srcslist) and themake protocopy loop to support multiple.protofiles per service package, so messagequeue contracts can later live alongside each service's RPC contract under the sameapi/{domain}/{service}/proto/dir.CLAUDE.mdproject layout / import paths / proto-gen workflow,example/README.md).The proto
packagedeclarations are intentionally left unchanged (onlygo_packagemoved) to avoid churning wire-level type names.Test plan
make buildmake test(54/54 pass)make check-gazellemake lintmake check-tidymake protoproduces zero drift vs committed stubsMade with Cursor