Adding Phabricator ChangeProvider#241
Merged
Merged
Conversation
ubettigole
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
ubettigole
force-pushed
the
phab_change_provider
branch
2 times, most recently
from
8a81862 to
127cb56
Compare
JamyDev
reviewed
Jun 17, 2026
ubettigole
force-pushed
the
phab_change_provider
branch
from
a296220 to
964ff95
Compare
ubettigole
force-pushed
the
phab_change_provider
branch
from
964ff95 to
fb875aa
Compare
behinddwalls
approved these changes
Jun 17, 2026
behinddwalls
temporarily deployed
to
stack-rebase
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
In order to get diff information for Phabricator ChangeIDs, we must implement a Phabricator ChangeProvider.
What?
This change creates a Phabricator ChangeProvider, similar to the existing GitHub ChangeProvider. Like the GitHub ChangeProvider, it:
[]ChangeInfoTest Plan
I created a temporary unit test (removed before committing) that pointed the Phabricator ChangeProvider at Uber's internal Phabricator instance, and confirmed that we could retrieve diff information by passing a bearer token, similar to the way we initialize the GitHub ChangeProvider in the example server.
All unit tests pass, with 99% coverage in the new
phabricatordirectory.