fix: close ephemeral Google ADK MCP toolsets#1668
Open
Sakshamm-Goyal wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1663
This PR closes each factory-created Google ADK
McpToolsetafter the generated list-tools and call-tool activities complete. The existing per-activity factory semantics are preserved; the change ensures the MCP session manager releases stdio subprocesses and other transport resources even when tool discovery or invocation raises.Details
Validation:
pytest -q -n0 tests/contrib/google_adk_agents/test_google_adk_agents.py -k mcp_toolset_provider_closes_factory_toolsetsruff check temporalio/contrib/google_adk_agents/_mcp.py tests/contrib/google_adk_agents/test_google_adk_agents.pyruff format --check temporalio/contrib/google_adk_agents/_mcp.py tests/contrib/google_adk_agents/test_google_adk_agents.py