Simplify buildings algorithm#918
Merged
Merged
Conversation
Owner
Author
|
Additional commit now optimises union_many by using an rtree to only join adjoining polygons. |
Owner
Author
|
Some very rough timings based on running Oxfordshire on an old Mac mini: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a specialised simplification algorithm for buildings, which aims to preserve their rectilinear nature while reducing vertices. You can try it out using a layer config like this:
It works best with
combine_polygons_below. Typical output is like this:from this source data:
The algorithm was developed in Ruby, and ported to C++ with the help of Claude.
Performance is moderate - there are some opportunities for optimisation (such as replacing atan2 with a faster implementation), but given that the main impact is from
combine_polygons_belowanyway, this isn't a massive deal.