Skip to content

style: add missing decimal#12937

Merged
kgryte merged 1 commit into
developfrom
philipp/style-erlang-mgf-decimal-2026-06-17
Jun 17, 2026
Merged

style: add missing decimal#12937
kgryte merged 1 commit into
developfrom
philipp/style-erlang-mgf-decimal-2026-06-17

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

Propagating the missing-decimal fix from 8e421b2b ("style: add missing decimal") to the sibling Erlang MGF C implementation. The JSDoc @example block in stats/base/dists/erlang/mgf/src/main.c called stdlib_base_dists_erlang_mgf( 0.3, 1, 1.0 ) — passing the integer literal 1 for the k shape parameter despite the function signature declaring k as const double. Replaces 1 with 1.0, mirroring the source commit's exact substitution.

Related Issues

None.

Questions

No.

Other

Split from PR #12934 per maintainer feedback: stdlib's squash-merge means the squashed commit type drives release semantics, so fix: and style: propagations must travel as separate PRs to avoid spurious patch releases for style:-only changes.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code on behalf of @Planeshifter as an automated propagation of fixes merged to develop over the prior 24 hours. Candidate source commits were filtered for generalizable patterns, sibling sites located via grep-able pattern signatures, and each proposed patch independently validated by parallel reviewer agents before commits were applied in the primary worktree. A human will audit and promote the PR out of draft.


@stdlib-js/reviewers


Generated by Claude Code

Propagates fix from 8e421b2 ("style: add missing decimal") to the
sibling Erlang MGF C implementation, whose JSDoc `@example` passed `1`
(integer literal) for the `k` shape parameter despite the function
signature declaring `k` as `const double`. Matches the source commit's
exact substitution.
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Jun 17, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/erlang/mgf $\\color{green}312/312$
$\\color{green}+100.00\\%$
$\\color{green}21/21$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}312/312$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte marked this pull request as ready for review June 17, 2026 21:42
@kgryte kgryte requested a review from a team June 17, 2026 21:42
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 17, 2026
@kgryte kgryte changed the title style: add missing decimal in stats/base/dists/erlang/mgf C example style: add missing decimal Jun 17, 2026
@kgryte kgryte merged commit b8c28ee into develop Jun 17, 2026
52 checks passed
@kgryte kgryte deleted the philipp/style-erlang-mgf-decimal-2026-06-17 branch June 17, 2026 21:43
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants