Skip to content

feat: add blas/ext/base/dnone#12885

Open
headlessNode wants to merge 7 commits into
stdlib-js:developfrom
headlessNode:blas/dnone
Open

feat: add blas/ext/base/dnone#12885
headlessNode wants to merge 7 commits into
stdlib-js:developfrom
headlessNode:blas/dnone

Conversation

@headlessNode

@headlessNode headlessNode commented Jun 14, 2026

Copy link
Copy Markdown
Member

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown_pkg_readmes status: passed
  • task: lint_markdown_docs status: na
  • task: lint_markdown status: na
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: missing_dependencies
  • task: lint_c_examples status: missing_dependencies
  • task: lint_c_benchmarks status: missing_dependencies
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves stdlib-js/metr-issue-tracker#812.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/base/dnone

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code.

@stdlib-js/reviewers

@headlessNode
feat: add blas/ext/base/dnone
df58aed 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. labels Jun 14, 2026
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jun 14, 2026
@stdlib-bot

stdlib-bot commented Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

headlessNode and others added 2 commits June 17, 2026 22:37
@headlessNode
Merge branch 'develop' into blas/dnone
366e6c3
@headlessNode
refactor: fix NaN handling
990ec43 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@headlessNode headlessNode marked this pull request as ready for review June 17, 2026 18:06
@headlessNode headlessNode requested a review from a team June 17, 2026 18:06
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 17, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 18, 2026
kgryte
kgryte reviewed Jun 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dnone/benchmark/c/benchmark.length.c Outdated
kgryte
kgryte reviewed Jun 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dnone/benchmark/c/benchmark.length.c Outdated
kgryte
kgryte reviewed Jun 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dnone/benchmark/c/benchmark.length.c Outdated
kgryte
kgryte reviewed Jun 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dnone/benchmark/c/benchmark.length.c Outdated
@kgryte
Apply suggestions from code review
9e6f5fe 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jun 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dnone/benchmark/c/benchmark.length.c
kgryte
kgryte reviewed Jun 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dnone/benchmark/c/benchmark.length.c Outdated
kgryte
kgryte reviewed Jun 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dnone/benchmark/c/benchmark.length.c
kgryte
kgryte reviewed Jun 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dnone/benchmark/c/benchmark.length.c Outdated
@kgryte
Apply suggestions from code review
92a698d 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jun 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dnone/benchmark/benchmark.js
* @returns {Function} benchmark function
*/
function createBenchmark( len ) {
var x = bernoulli( len, 0.5, options );

@kgryte kgryte Jun 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about this benchmark for a moment. Why is it not informative? What happens if you run this multiple times? Are the results reproducible? Do they test any sort of pathologic case? What happens when x[0] is truthy for len = 1e6 but, for len = 10, all values in x randomly happen to be falsy? What conclusions can you draw? The reality is that you can't draw any conclusions because the benchmarks as you've written here are meaningless.

kgryte
kgryte reviewed Jun 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dnone/src/addon.c
STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 1 );
napi_value v;
napi_get_boolean( env, API_SUFFIX(stdlib_strided_dnone)( N, X, strideX ), &v );

@kgryte kgryte Jun 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this may work, this is not the desired implementation. We need to create a macro similar to what we have for create-int32, create-double, etc (see https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/napi). This package should be napi/create-boolean and is a prerequisite for this package to move forward.

kgryte
kgryte requested changes Jun 18, 2026
View reviewed changes

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the benchmarks and the missing prerequisite, this is coming along.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. review: 2 labels Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. Needs Changes Pull request which needs changes before being merged. review: 2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/ext/base/dnone

3 participants

@headlessNode @stdlib-bot @kgryte