Add correct license expression in invalid license expressions#423
Merged
Conversation
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
Adds a unit test for the SPDX V2 compatible parser. There already exists a unit test for SPDX V3 expressions. Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
bact
approved these changes
Jun 24, 2026
bact
reviewed
Jun 24, 2026
…TestV2.java Co-authored-by: Arthit Suriyawongkul <arthit@gmail.com> Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
Collaborator
|
My bad. I was suggesting a Python style comment (using #) instead of Java // or /* block. The build failed badly because of that |
Collaborator
|
To fix the comments by #426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds unit tests for invalid license expressions when just an exception ID is found without a "with" clause for the V2 parser.