feat: add support for 'features.agent_view' app manifest property#596
Open
mwbrooks wants to merge 2 commits into
Open
feat: add support for 'features.agent_view' app manifest property#596mwbrooks wants to merge 2 commits into
mwbrooks wants to merge 2 commits into
Conversation
Adds AgentView and AgentViewAction structs and an AgentView field on AppFeatures so manifests using the new agent_view property survive JSON/YAML round-trips through the CLI. Mirrors AssistantView and reuses the existing SuggestedPrompts type.
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
=======================================
Coverage 71.67% 71.67%
=======================================
Files 226 226
Lines 19176 19176
=======================================
Hits 13745 13745
Misses 4220 4220
Partials 1211 1211 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The agent_view JSON marshal cases live in Test_AppManifest_AppFeatures alongside other features. The standalone round-trip test had no precedent for sibling properties like assistant_view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
Supports the upcoming
features.agent_viewin the Slack app manifest. Without these struct changes the CLI silently dropsagent_viewwhen reading and writing a manifest.AssistantViewshape and reuses the existingSuggestedPromptstype becauseagent_viewandassistant_vieware sibling properties.Related: slackapi/manifest-schema#74
Preview
Testing
Requirements