Implement Conjugate Data in UI#625
Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
@angrezichatterbox, do you want to fix the linting errors? I can then do a review. Note that I've also edited your commit message to close the issues via our conversation :) |
|
Minor points here that we could do as a part of this, @angrezichatterbox:
Aside from the above, this is a solid WIP! Will give it a final check and bring it in once the above's done 😊 |
|
@andrewtavis this is ready for review : ) |
|
Amazing, @angrezichatterbox! Note: @prince-0408 that the changes for Scribe-i18n will come in via this PR, so you'll need to rebase your PR with the new version of Scribe-Android and Scribe-i18n once this is brought in. |
Thanks for the heads-up, @andrewtavis ! I'll keep an eye on this and rebase my branch/sync the submodule pointer once PR this is merged. |
andrewtavis
left a comment
There was a problem hiding this comment.
All this is looking amazing, @angrezichatterbox! Such nice work on the interface :) Looking forward to finalizing for the other languages and doing the final cleanups for Scribe-Conjugate-Android!

Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR adds the conjuagte view and handling for english and swedish
Related issue