fix: reload on route manifest metadata changes#58
Conversation
1f2dcfd to
88aa4ec
Compare
7e75bfb to
a38d779
Compare
Benchmark ResultsCompared PR head Total median wall time: 12.03s -> 11.83s (-1.7%, 1.02x speedup)
Profile: |
88aa4ec to
8b08bd7
Compare
a38d779 to
6ab91d0
Compare
90ec8f4 to
d20c605
Compare
d62c5f2 to
b09e3a9
Compare
commit: |
|
Warning Review limit reached
Next review available in: 34 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughA new 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/dev-generation.ts`:
- Around line 589-591: Coalesce the duplicate full-reload path in the mixed CSS
+ route metadata update flow: `notifyRouteManifestChanged()` in
`src/dev-generation.ts` can be reached after the CSS ownership notification
path, and both end up triggering the same `server.sockWrite('full-reload', {
path: '*' })` behavior in `dev-runtime-controller`. Update the decision logic
around the CSS notification and `routeManifestMetadataChanged` handling so a
single rebuild attempt only emits one hard-reload, using the existing
`notifyRouteManifestChanged`/CSS notification branches as the points to dedupe.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d0d36390-a048-4803-b14b-7ded15ca891a
📒 Files selected for processing (6)
src/dev-generation.tssrc/dev-runtime-controller.tstests/dev-generation-fixtures.tstests/dev-generation.test.tstests/dev-runtime-controller.test.tstests/dev-runtime-fixtures.ts
Summary
Validation
pnpm test:corepnpm buildgit diff --checkNotes
Stacked on
codex/asset-query-parity. This intentionally chooses the conservative full-reload fallback because the Rsbuild plugin does not currently ship React Router's Vite route-HMR runtime.