Skip to content

fix: preserve mixed asset query semantics#57

Merged
ScriptedAlchemy merged 4 commits into
mainfrom
codex/asset-query-parity
Jun 29, 2026
Merged

fix: preserve mixed asset query semantics#57
ScriptedAlchemy merged 4 commits into
mainfrom
codex/asset-query-parity

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • tighten the generic non-CSS ?url asset rule so it does not steal mixed ?url&raw or ?url&inline requests
  • preserve CSS ?url handling outside the generic asset rule
  • add coverage for query ordering and mixed-query exclusions
  • add a patch changeset

Validation

  • pnpm exec prettier --check src/index.ts tests/features.test.ts .changeset/mixed-url-assets.md
  • pnpm test:core tests/features.test.ts tests/dev-runtime.integration.test.ts
  • pnpm test:core
  • pnpm build

Notes

Restacked directly on current main after PR #56 merged.

@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/asset-query-parity branch from 1f2dcfd to 88aa4ec Compare June 27, 2026 06:06
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/config-dependency-watch branch from 8772c70 to b0a7155 Compare June 27, 2026 06:06
@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

Compared PR head 7e52300 against base 9352787.

Total median wall time: 12.22s -> 12.23s (+0.1%, 1.00x speedup)
Compiler ready median: 10.06s -> 10.07s (+0.1%)
Route load median: 2.09s -> 2.08s (-0.1%)

Benchmark Base total Head total Delta Head ready Head routes Speedup Head RSS p95
large-355-ssr-esm 12.22s 12.23s +0.1% 10.07s 2.08s 1.00x -

Profile: large; mode: dev; iterations: 5; warmup: 0.
Workflow run

@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/asset-query-parity branch from 88aa4ec to 8b08bd7 Compare June 28, 2026 19:58
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/config-dependency-watch branch 4 times, most recently from b0af8f5 to 7c0269c Compare June 29, 2026 05:32
Base automatically changed from codex/config-dependency-watch to main June 29, 2026 06:50
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/asset-query-parity branch from 90ec8f4 to d20c605 Compare June 29, 2026 06:59
@pkg-pr-new

pkg-pr-new Bot commented Jun 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/rsbuild-plugin-react-router@7e52300

commit: 7e52300

@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review June 29, 2026 07:03
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e621c741-d613-4e3f-a946-04a289507360

📥 Commits

Reviewing files that changed from the base of the PR and between d20c605 and 7e52300.

📒 Files selected for processing (1)
  • tests/features.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/features.test.ts

📝 Walkthrough

Walkthrough

The urlAssetResourceQuery regex in src/index.ts is tightened to match url as a standalone query parameter while explicitly excluding queries containing raw or inline. Tests in tests/features.test.ts are updated with explicit include/exclude query pattern lists to verify the new regex behavior. A changeset entry documents the patch.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: preserving mixed asset query semantics.
Description check ✅ Passed The description directly matches the implemented changes and validation steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/asset-query-parity

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: dependency version conflict. Check your lock file or package.json.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ScriptedAlchemy ScriptedAlchemy merged commit 3f6db5c into main Jun 29, 2026
7 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the codex/asset-query-parity branch June 29, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant