Skip to content

[codex] adopt Effect for transform executor cleanup#55

Open
ScriptedAlchemy wants to merge 14 commits into
codex/parallel-dev-compilersfrom
codex/effectts-scheduling
Open

[codex] adopt Effect for transform executor cleanup#55
ScriptedAlchemy wants to merge 14 commits into
codex/parallel-dev-compilersfrom
codex/effectts-scheduling

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Collaborator

Summary

  • documents the incremental Effect adoption design and implementation plan
  • adds effect as an internal runtime dependency
  • introduces a small Effect boundary helper for plugin internals
  • migrates route transform executor close cleanup to an Effect-backed program while preserving the existing Promise API
  • adds lifecycle coverage for in-flight close rejection, idempotent close, run-after-close inline fallback, and source-cache recovery after postMessage failure

Notes

This PR is stacked on codex/parallel-dev-compilers. Effect is kept out of generated React Router framework code and out of public plugin APIs.

Verification

  • corepack pnpm exec rstest run -c ./rstest.config.ts tests/parallel-route-transforms.test.ts
  • corepack pnpm run test:core
  • corepack pnpm exec tsc --noEmit
  • corepack pnpm run format:check
  • corepack pnpm run build
  • corepack pnpm run test:package-interop
  • git diff --check

@ScriptedAlchemy ScriptedAlchemy changed the base branch from codex/parallel-dev-compilers to main June 26, 2026 23:48
@ScriptedAlchemy ScriptedAlchemy changed the base branch from main to codex/parallel-dev-compilers June 26, 2026 23:48
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/effectts-scheduling branch 2 times, most recently from acd41d9 to 01df6b5 Compare June 27, 2026 00:22
@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review June 27, 2026 00:22
@ScriptedAlchemy ScriptedAlchemy changed the base branch from codex/parallel-dev-compilers to main June 27, 2026 00:23
@pkg-pr-new

pkg-pr-new Bot commented Jun 27, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/rsbuild-plugin-react-router@01df6b5

commit: 01df6b5

@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

Compared PR head 928b383 against base 2d960ac.

Total median wall time: 11.08s -> 10.03s (-9.5%, 1.11x speedup)
Compiler ready median: 9.20s -> 8.04s (-12.6%)
Route load median: 1.83s -> 1.85s (+1.2%)

Benchmark Base total Head total Delta Head ready Head routes Speedup Head RSS p95
large-355-ssr-esm 11.08s 10.03s -9.5% 8.04s 1.85s 1.11x -

Profile: large; mode: dev; iterations: 10; warmup: 0.
Workflow run

@ScriptedAlchemy ScriptedAlchemy changed the base branch from main to codex/parallel-dev-compilers June 27, 2026 00:29
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/parallel-dev-compilers branch from 6ad99ea to e16d85f Compare June 27, 2026 00:49
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/effectts-scheduling branch 2 times, most recently from 935996f to 58ff49e Compare June 27, 2026 01:10
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/parallel-dev-compilers branch from dff4b2a to 559bb2e Compare June 27, 2026 01:31
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/effectts-scheduling branch from 58ff49e to 00eba5a Compare June 27, 2026 01:31
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/parallel-dev-compilers branch from 559bb2e to 0c1f1e5 Compare June 27, 2026 02:43
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/effectts-scheduling branch 2 times, most recently from 95e07a1 to 00c6b29 Compare June 27, 2026 03:11
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/effectts-scheduling branch from 00c6b29 to 5cce881 Compare June 27, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant