[codex] adopt Effect for transform executor cleanup#55
Open
ScriptedAlchemy wants to merge 14 commits into
Open
[codex] adopt Effect for transform executor cleanup#55ScriptedAlchemy wants to merge 14 commits into
ScriptedAlchemy wants to merge 14 commits into
Conversation
acd41d9 to
01df6b5
Compare
commit: |
Contributor
Benchmark ResultsCompared PR head Total median wall time: 11.08s -> 10.03s (-9.5%, 1.11x speedup)
Profile: |
6ad99ea to
e16d85f
Compare
935996f to
58ff49e
Compare
dff4b2a to
559bb2e
Compare
58ff49e to
00eba5a
Compare
559bb2e to
0c1f1e5
Compare
95e07a1 to
00c6b29
Compare
00c6b29 to
5cce881
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effectas an internal runtime dependencypostMessagefailureNotes
This PR is stacked on
codex/parallel-dev-compilers. Effect is kept out of generated React Router framework code and out of public plugin APIs.Verification
corepack pnpm exec rstest run -c ./rstest.config.ts tests/parallel-route-transforms.test.tscorepack pnpm run test:corecorepack pnpm exec tsc --noEmitcorepack pnpm run format:checkcorepack pnpm run buildcorepack pnpm run test:package-interopgit diff --check