Skip to content

[codex] Preserve CSS re-add reload state#53

Merged
ScriptedAlchemy merged 1 commit into
perf/bundling-performancefrom
codex/css-hmr-readd-reload
Jun 26, 2026
Merged

[codex] Preserve CSS re-add reload state#53
ScriptedAlchemy merged 1 commit into
perf/bundling-performancefrom
codex/css-hmr-readd-reload

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Collaborator

Summary

  • keep the post-removal CSS reload state armed through unrelated web updates
  • only fire the follow-up hard reload when CSS ownership is actually added back
  • add a unit regression covering content-only web updates between removal and re-add

Context

This stacks on PR #39. The base branch already fails closed for lazy extracted-CSS ownership removal; this follow-up tightens the state machine so normal web HMR is preserved after a removal until CSS is re-added.

Validation

  • pnpm test:core tests/dev-generation.test.ts tests/dev-runtime-controller.test.ts
  • pnpm build
  • pnpm --filter ./examples/default-template test:e2e:lazy
  • pnpm test:core
  • git diff --check
  • pnpm exec prettier --check src/dev-generation.ts tests/dev-generation.test.ts
  • pnpm test:package-interop
  • pnpm bench:smoke (synthetic-48 SSR ESM: 1.53s wall, 259428 KB max RSS)

@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review June 26, 2026 15:41
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/css-hmr-readd-reload branch from 24daf1b to e79b893 Compare June 26, 2026 15:49
@ScriptedAlchemy ScriptedAlchemy merged commit eb93b70 into perf/bundling-performance Jun 26, 2026
@ScriptedAlchemy ScriptedAlchemy deleted the codex/css-hmr-readd-reload branch June 26, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant