fix(#3527): resolve SonarQube code quality issues in lightspeed workspace#3545
Closed
fullsend-ai-coder[bot] wants to merge 2 commits into
Closed
fix(#3527): resolve SonarQube code quality issues in lightspeed workspace#3545fullsend-ai-coder[bot] wants to merge 2 commits into
fullsend-ai-coder[bot] wants to merge 2 commits into
Conversation
fullsend-ai-coder
Bot
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3545 +/- ##
==========================================
- Coverage 52.60% 52.59% -0.01%
==========================================
Files 2273 2273
Lines 86812 86805 -7
Branches 24309 24321 +12
==========================================
- Hits 45667 45657 -10
- Misses 40935 40938 +3
Partials 210 210
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Member
|
/fs-fix regenerate api reports |
Contributor
Author
|
🤖 Finished Fix · ✅ Success · Started 8:50 PM UTC · Completed 9:04 PM UTC |
Address multiple SonarQube rule violations across the lightspeed workspace: - S101: Rename interface to PascalCase (UseAutoScrollOptions) - S125: Remove commented-out code - S1301: Replace single-case switch with if statement - S1788: Move default parameters to end of parameter list - S1854: Remove useless variable assignment - S2486: Remove unused catch binding - S2933: Mark never-reassigned members as readonly - S3735: Remove unnecessary void operator usage - S4030: Remove unused collection - S4325: Remove unnecessary type assertions - S4623: Remove redundant undefined parameters - S4782: Remove redundant undefined type with optional marker - S6479: Use meaningful keys instead of array indices - S6557: Use String#startsWith instead of regex - S6582: Use optional chaining - S6606: Use nullish coalescing operator - S6653: Use Object.hasOwn() - S6671: Use Error object for Promise rejection - S6748: Fix children prop passing in createElement - S6819: Use output element instead of status role - S7722: Use non-empty error message in test - S7735: Fix negated conditions - S7744: Remove useless empty objects - S7747: Remove unnecessary array cloning in for...of - S7762: Use childNode.remove() - S7764: Use globalThis instead of global/window - S7770: Replace identity wrapper with String directly - S7772: Use node: prefix for built-in module imports - S7773: Use Number.parseInt/parseFloat - S7778: Combine consecutive Array#push calls - S7780: Use String.raw for escaped backslashes - S7781: Use String#replaceAll instead of replace with global regex - S7784: Use structuredClone instead of JSON.parse(JSON.stringify) - S7787: Remove empty export statements Closes #3527 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fullsend-ai-coder
Bot
force-pushed
the
fix/sonarqube-lightspeed-issues-3527
branch
from
835c106 to
8e4dd2a
Compare
Re-run `yarn build:api-reports` to update report-alpha.api.md with correct property ordering from API Extractor. Addresses human instruction on #3545 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
🔧 Fix agent — iteration 1 (human-triggered)Regenerated API reports per human instruction. The report-alpha.api.md file was updated with correct property ordering produced by API Extractor. Fixed (1):
Tests: passed Updated by fullsend fix agent |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address multiple SonarQube rule violations across the lightspeed workspace:
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Closes #3527
Post-script verification
fix/sonarqube-lightspeed-issues-3527)870f011227023f9362903b9195f4755dec763d00..HEAD)