Replay indexing plans after indexer restarts#6596
Draft
fmassot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the second focused extraction from #6592 and is independent of #6595.
Root cause
The scheduler compared stable node IDs and indexing tasks, but not process generations. An indexer could restart with the same node ID and appear unchanged, causing both periodic reconciliation and a plan rebuild to skip dispatching the current plan.
Ready-indexer apply futures also had no independent hard deadline. A local or otherwise unlayered client that never completed could retain the rebuild-completion guard indefinitely. Draining indexers already had a two-second deadline.
Behavior
NodeIdand covers every dispatch-eligible node, including nodes omitted from the physical plan that must receive an empty cleanup plan.Validation
control_running_planandrebuild_plancargo test -p quickwit-control-plane --all-features --lib(123 passed)cargo clippy -p quickwit-control-plane --all-features --tests -- -D warningscargo +nightly fmt --all -- --checkcargo doc -p quickwit-control-plane --all-features --no-depsbash scripts/check_license_headers.shbash scripts/check_log_format.shgit diff --checkThe regressions exercise the scheduler through
IndexingServiceClienttest clients; this draft does not add a full multi-node process-restart integration test.