search: add query_ast, counts, and warmup byte span attributes#6588
search: add query_ast, counts, and warmup byte span attributes#6588loutPhilipps wants to merge 1 commit into
Conversation
Adds query AST, split and doc count, time range to the root_search span attributes, and warmup_mb/downloaded_mb attributes on the warmup span. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 248f437efe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ); | ||
| warmup_span.record( | ||
| "downloaded_mb", | ||
| download_counters.snapshot().0 as f64 / BYTES_PER_MB, |
There was a problem hiding this comment.
When the split footer or split-cache entry is cold, this value includes reads that happened before the warmup span even started: the storage is wrapped by CountingStorage before open_index_with_caches, and open_split_bundle may fetch the split footer with get_slice before warmup_start. Recording the cumulative snapshot().0 here therefore attributes pre-warmup downloads to the warmup span and overstates warmup download volume on cold-cache searches; capture a baseline after opening the index or subtract the pre-warmup count.
Useful? React with 👍 / 👎.
1 participant
root_searchspan attributeswarmup_mbanddownloaded_mbas attributes on the warmup span🤖 Generated with Claude Code