Fix #144: Automatically strip port 3306 from connection strings#211
Open
Vishhh03 wants to merge 1 commit into
Open
Fix #144: Automatically strip port 3306 from connection strings#211Vishhh03 wants to merge 1 commit into
Vishhh03 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144
I updated the
buildURLfunction insrc/index.tsto automatically ignoreport 3306when generating the connection URL if it's found in theconfig.url.I also updated the Connection class constructor to strip 3306 directly from
config.hostif you pass the connection properties separately (e.g., host, username, password), coercing it properly to standard HTTPS (port 443).I added a couple of test cases in
__tests__/index.test.tsto verify that 3306 is properly stripped in both scenarios.