Fix missing semicolon in mm session validate_sid handler#22336
Open
iliaal wants to merge 1 commit into
Open
Conversation
PS_VALIDATE_SID_FUNC(mm) was missing the semicolon after the ps_mm_key_exists() assignment, so ext/session/mod_mm.c failed to compile under --with-mm. The file is gated behind HAVE_LIBMM, so default builds and CI never exercised it. Closes phpGH-22336
iliaal
force-pushed
the
fix-session-mm-semicolon
branch
from
39fe16d to
f767f4a
Compare
iluuu1994
approved these changes
Jun 17, 2026
iluuu1994
left a comment
iluuu1994
left a comment
Member
There was a problem hiding this comment.
No knowledge about this file, but the change at least looks correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PS_VALIDATE_SID_FUNC(mm) is missing the semicolon after the ps_mm_key_exists() assignment, so ext/session/mod_mm.c fails to compile under --with-mm. The handler is gated behind HAVE_LIBMM, so default builds and CI never exercise it.