feat: faster replication#1166
Conversation
|
I am still working on the design for it, just a peak if the direction seems well @levkk |
|
Cool! Would be good to see some benchmark numbers, just to get a sense of how much faster this is. |
|
Do you have any such setup so that i can benchmark it? |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This might work: Specifically, see |
|
RUNS = 2
@levkk results seems good but also too good at a point |
|
Async should be a big improvement, so not that surprising. This is very cool. Let me know when you're ready for a review, I'll tag Kiryl. |
|
@levkk ready for review |
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod test { |
There was a problem hiding this comment.
Do you think we should add more unit tests here? I think we should have some for testing the whole flow - prepare -> execute -> await. And also some tests for possible errors



fixes #1036