Skip to content

fix(AngleRightIcon): Replace AngleRightIcon with RhMicronsCaretRightIcon #12496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebeccaalpert wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(AngleRightIcon): Replace AngleRightIcon with RhMicronsCaretRightIcon #12496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/DualListSelector/examples/DualListSelector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { Fragment, useEffect, useMemo, useState } from 'react';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';

interface Option {
text: string;
Expand Down Expand Up @@ -105,7 +105,7 @@ export const DualListSelectorBasic: React.FunctionComponent = () => {
isDisabled={!availableOptions.some((option) => option.selected)}
onClick={() => moveSelected(true)}
aria-label="Add selected"
icon={<AngleRightIcon />}
icon={<RhMicronsCaretRightIcon />}
/>
<DualListSelectorControl
isDisabled={availableOptions.length === 0}
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';

interface Option {
Expand Down Expand Up @@ -153,7 +153,7 @@ export const DualListSelectorSearch: React.FunctionComponent = () => {
isDisabled={!availableOptions.some((option) => option.selected)}
onClick={() => moveSelected(true)}
aria-label="Add selected"
icon={<AngleRightIcon />}
icon={<RhMicronsCaretRightIcon />}
/>
<DualListSelectorControl
isDisabled={availableOptions.length === 0}
Expand Down
4 changes: 2 additions & 2 deletions ...ges/react-core/src/components/DualListSelector/examples/DualListSelectorBasicTooltips.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';

interface Option {
text: string;
Expand Down Expand Up @@ -107,7 +107,7 @@ export const DualListSelectorBasic: React.FunctionComponent = () => {
aria-label="Add selected"
tooltipContent="Add selected"
tooltipProps={{ position: 'top', 'aria-live': 'off' }}
icon={<AngleRightIcon />}
icon={<RhMicronsCaretRightIcon />}
/>
<DualListSelectorControl
isDisabled={availableOptions.length === 0}
Expand Down
4 changes: 2 additions & 2 deletions ...t-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import {
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';
Expand Down Expand Up @@ -271,7 +271,7 @@ export const DualListSelectorComplexOptionsActionsNext: React.FunctionComponent
isDisabled={!availableOptions.some((option) => option.selected) || isDisabled}
onClick={() => moveSelected(true)}
aria-label="Add selected"
icon={<AngleRightIcon />}
icon={<RhMicronsCaretRightIcon />}
/>
<DualListSelectorControl
isDisabled={availableOptions.length === 0 || isDisabled}
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/DualListSelector/examples/DualListSelectorTree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';

interface FoodNode {
Expand Down Expand Up @@ -290,7 +290,7 @@ export const DualListSelectorComposableTree: React.FunctionComponent<ExampleProp
isDisabled={!checkedLeafIds.filter((x) => visibleAvailableLeafIds.includes(x)).length}
onClick={() => moveChecked(true)}
aria-label="Add selected"
icon={<AngleRightIcon />}
icon={<RhMicronsCaretRightIcon />}
/>
<DualListSelectorControl
isDisabled={chosenLeafIds.length === memoizedAllLeaves.length}
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Pagination/PaginationNavigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import styles from '@patternfly/react-styles/css/components/Pagination/paginatio
import { css } from '@patternfly/react-styles';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import { Button, ButtonVariant } from '../Button';
import { TextInput } from '../TextInput';
Expand Down Expand Up @@ -247,7 +247,7 @@ class PaginationNavigation extends Component<PaginationNavigationProps, Paginati
this.handleNewPage(event, newPage);
this.setState({ userInputPage: newPage });
}}
icon={<AngleRightIcon />}
icon={<RhMicronsCaretRightIcon />}
/>
</div>
{!isCompact && (
Expand Down
20 changes: 4 additions & 16 deletions ...omponents/Pagination/__tests__/Generated/__snapshots__/PaginationNavigation.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,24 +126,12 @@ exports[`Navigation should match snapshot (auto-generated) 1`] = `
fill="currentColor"
height="1em"
role="img"
viewBox="0 0 20 20"
width="1em"
>
<svg
class="pf-v6-icon-default"
viewBox="0 0 256 512"
>
<path
d="M224.3 273l-136 136c-9.4 9.4-24.6 9.4-33.9 0l-22.6-22.6c-9.4-9.4-9.4-24.6 0-33.9l96.4-96.4-96.4-96.4c-9.4-9.4-9.4-24.6 0-33.9L54.3 103c9.4-9.4 24.6-9.4 33.9 0l136 136c9.5 9.4 9.5 24.6.1 34z"
/>
</svg>
<svg
class="pf-v6-icon-rh-ui"
viewBox="0 0 32 32"
>
<path
d="M11 30a.999.999 0 0 1-.707-1.707L22.586 16 10.293 3.707a.999.999 0 1 1 1.414-1.414l12.646 12.646a1.501 1.501 0 0 1 0 2.121L11.707 29.706a.997.997 0 0 1-.707.293Z"
/>
</svg>
<path
d="M14.35 8.94 6.71 1.29l-.02-.02c-.4-.38-1.03-.37-1.41.02-.38.4-.37 1.03.02 1.41l7.29 7.29-7.29 7.29a1.003 1.003 0 0 0 1.42 1.42l7.65-7.65c.59-.59.59-1.54 0-2.12Z"
/>
</svg>
</span>
</button>
Expand Down
Loading
Loading