Skip to content

fix(AngleDoubleRightIcon): Replace AngleDoubleRightIcon with RhMicronsDoubleCaretRightIcon #12493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebeccaalpert wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(AngleDoubleRightIcon): Replace AngleDoubleRightIcon with RhMicronsDoubleCaretRightIcon #12493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/DualListSelector/examples/DualListSelector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ propComponents:
import { Fragment, useEffect, useMemo, useState } from 'react';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import RhMicronsDoubleCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from '@patternfly/react-core';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import RhMicronsDoubleCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';

interface Option {
Expand Down Expand Up @@ -111,7 +111,7 @@ export const DualListSelectorBasic: React.FunctionComponent = () => {
isDisabled={availableOptions.length === 0}
onClick={() => moveAll(true)}
aria-label="Add all"
icon={<AngleDoubleRightIcon />}
icon={<RhMicronsDoubleCaretRightIcon />}
/>
<DualListSelectorControl
isDisabled={chosenOptions.length === 0}
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
} from '@patternfly/react-core';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import RhMicronsDoubleCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';

Expand Down Expand Up @@ -159,7 +159,7 @@ export const DualListSelectorSearch: React.FunctionComponent = () => {
isDisabled={availableOptions.length === 0}
onClick={() => moveAll(true)}
aria-label="Add all"
icon={<AngleDoubleRightIcon />}
icon={<RhMicronsDoubleCaretRightIcon />}
/>
<DualListSelectorControl
isDisabled={chosenOptions.length === 0}
Expand Down
4 changes: 2 additions & 2 deletions ...ges/react-core/src/components/DualListSelector/examples/DualListSelectorBasicTooltips.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from '@patternfly/react-core';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import RhMicronsDoubleCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';

interface Option {
Expand Down Expand Up @@ -115,7 +115,7 @@ export const DualListSelectorBasic: React.FunctionComponent = () => {
aria-label="Add all"
tooltipContent="Add all"
tooltipProps={{ position: 'right', 'aria-live': 'off' }}
icon={<AngleDoubleRightIcon />}
icon={<RhMicronsDoubleCaretRightIcon />}
/>
<DualListSelectorControl
isDisabled={chosenOptions.length === 0}
Expand Down
4 changes: 2 additions & 2 deletions ...t-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
} from '@patternfly/react-core';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import RhMicronsDoubleCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import RhMicronsSortDownSmallToLargeIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-sort-down-small-to-large-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';
Expand Down Expand Up @@ -277,7 +277,7 @@ export const DualListSelectorComplexOptionsActionsNext: React.FunctionComponent
isDisabled={availableOptions.length === 0 || isDisabled}
onClick={() => moveAll(true)}
aria-label="Add all"
icon={<AngleDoubleRightIcon />}
icon={<RhMicronsDoubleCaretRightIcon />}
/>
<DualListSelectorControl
isDisabled={chosenOptions.length === 0 || isDisabled}
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/DualListSelector/examples/DualListSelectorTree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
} from '@patternfly/react-core';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import RhMicronsDoubleCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-right-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon';

Expand Down Expand Up @@ -296,7 +296,7 @@ export const DualListSelectorComposableTree: React.FunctionComponent<ExampleProp
isDisabled={chosenLeafIds.length === memoizedAllLeaves.length}
onClick={() => moveAll(true)}
aria-label="Add all"
icon={<AngleDoubleRightIcon />}
icon={<RhMicronsDoubleCaretRightIcon />}
/>
<DualListSelectorControl
isDisabled={chosenLeafIds.length === 0}
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Pagination/PaginationNavigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { css } from '@patternfly/react-styles';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import RhMicronsDoubleCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-left-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import AngleDoubleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-double-right-icon';
import RhMicronsDoubleCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-double-caret-right-icon';
import { Button, ButtonVariant } from '../Button';
import { TextInput } from '../TextInput';
import { OnSetPage } from './Pagination';
Expand Down Expand Up @@ -262,7 +262,7 @@ class PaginationNavigation extends Component<PaginationNavigationProps, Paginati
this.handleNewPage(event, lastPage);
this.setState({ userInputPage: lastPage });
}}
icon={<AngleDoubleRightIcon />}
icon={<RhMicronsDoubleCaretRightIcon />}
/>
</div>
)}
Expand Down
20 changes: 4 additions & 16 deletions ...omponents/Pagination/__tests__/Generated/__snapshots__/PaginationNavigation.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,24 +169,12 @@ exports[`Navigation should match snapshot (auto-generated) 1`] = `
fill="currentColor"
height="1em"
role="img"
viewBox="0 0 20 20"
width="1em"
>
<svg
class="pf-v6-icon-default"
viewBox="0 0 448 512"
>
<path
d="M224.3 273l-136 136c-9.4 9.4-24.6 9.4-33.9 0l-22.6-22.6c-9.4-9.4-9.4-24.6 0-33.9l96.4-96.4-96.4-96.4c-9.4-9.4-9.4-24.6 0-33.9L54.3 103c9.4-9.4 24.6-9.4 33.9 0l136 136c9.5 9.4 9.5 24.6.1 34zm192-34l-136-136c-9.4-9.4-24.6-9.4-33.9 0l-22.6 22.6c-9.4 9.4-9.4 24.6 0 33.9l96.4 96.4-96.4 96.4c-9.4 9.4-9.4 24.6 0 33.9l22.6 22.6c9.4 9.4 24.6 9.4 33.9 0l136-136c9.4-9.2 9.4-24.4 0-33.8z"
/>
</svg>
<svg
class="pf-v6-icon-rh-ui"
viewBox="0 0 32 32"
>
<path
d="M30.354 17.061 17.708 29.707a.997.997 0 0 1-1.414 0 .999.999 0 0 1 0-1.414L28.587 16 16.293 3.707a.999.999 0 1 1 1.414-1.414l12.646 12.646a1.501 1.501 0 0 1 0 2.121Zm-14-2.122L3.707 2.293a.999.999 0 1 0-1.414 1.414L14.586 16 2.293 28.293a.999.999 0 1 0 1.414 1.414l12.646-12.646a1.501 1.501 0 0 0 0-2.121Z"
/>
</svg>
<path
d="M10 19a1 1 0 0 1-.707-1.707L16.586 10 9.293 2.707a1 1 0 1 1 1.414-1.414l7.647 7.646c.283.284.439.66.439 1.061s-.156.777-.44 1.06l-7.646 7.647A.997.997 0 0 1 10 19Zm-7.293-.293 7.647-7.646c.283-.284.439-.66.439-1.061s-.156-.777-.44-1.06L2.708 1.292a1 1 0 1 0-1.414 1.414L8.586 10l-7.293 7.293a1 1 0 1 0 1.414 1.414Z"
/>
</svg>
</span>
</button>
Expand Down
Loading
Loading