fix(rtl-demo): update paginated table and status labels#12491
Open
andrew-ronaldson wants to merge 1 commit into
Open
fix(rtl-demo): update paginated table and status labels#12491andrew-ronaldson wants to merge 1 commit into
andrew-ronaldson wants to merge 1 commit into
Conversation
- Remove Card wrapper so toolbar and table render directly on the page - Switch status labels from color variants to semantic LabelStatus props - Fix button and label icons to use pf-v6-m-mirror-inline-rtl directly, removing the Icon wrapper that was overriding on-brand icon color tokens Co-authored-by: Cursor <cursoragent@cursor.com>
Walkthrough
ChangesRTL Demo: PaginatedTable refactor
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-react-pr-12491.surge.sh A11y report: https://pf-react-pr-12491-a11y.surge.sh |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12491
Note: This was vibe coded by PF Design team.
What: Closes #
Additional issues:
Summary by CodeRabbit
Bug Fixes
Style