fix: recalculate grid span count after rotation#4894
Conversation
|
Hi @himu-gupta! Thanks for opening this PR! 🙌🏻 Some improvements here before the CR:
Let us know if you have any doubts and we will help you! I will start with the code review when all changes are done 🍻 |
4a35526 to
bc59543
Compare
Signed-off-by: Himanshu Gupta <himu.gupta23@gmail.com>
Signed-off-by: Himanshu Gupta <himu.gupta23@gmail.com>
bc59543 to
c889d0b
Compare
Thanks @joragua, I have done the requested changes. |
|
Thanks for your contribution @himu-gupta!! Let me tell you how the process is. Basically, there are two phases after the PR is correct (signed commits, separated changelog, conventional commits correct...):
For sure, all CI checks must be green as well, otherwise merging will be blocked. Code review will start soon, keep tuned!! |
Thanks for the insight |
Summary
Fixes #4884
Verification
JAVA_HOME="/Applications/Android Studio.app/Contents/jbr/Contents/Home" ANDROID_HOME="/Users/himu/Library/Android/sdk" ./gradlew --no-daemon --console=plain :owncloudApp:compileOriginalDebugKotlingit diff --check