Few suggestions for #2844#6
Open
ViezeVingertjes wants to merge 2 commits into
Open
Conversation
… flag across all radio types
…fault pref for rx boosted gain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few things came up while reviewing meshcore-dev#2844:
return falseinESPNOWRadio.LR1110so boosted gain isn't disabled by default.I also took the opportunity to unify
SX126X_RX_BOOSTED_GAINwith the existingRX_BOOSTED_GAIN, so all radio types now use the same build flag. But feel free to cherrypick/ignore/whatever you feel like. ^^