Skip to content

fix(file-upload-worker): better error handling#17191

Merged
alperozturk96 merged 4 commits into
masterfrom
fix/file-upload-worker-better-error-handling
Jun 22, 2026
Merged

fix(file-upload-worker): better error handling#17191
alperozturk96 merged 4 commits into
masterfrom
fix/file-upload-worker-better-error-handling

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Library PR: nextcloud/android-library#2046

Changes

  • Depends on the upload result sets worker state
  • Only tries to generate a thumbnail if the upload actually succeeded

@alperozturk96 alperozturk96 added this to the Nextcloud App 34.0.1 milestone Jun 16, 2026
@alperozturk96 alperozturk96 mentioned this pull request Jun 16, 2026
Merged
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27615301759/artifacts/7666407359
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96

alperozturk96 commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-34.0.x

@alperozturk96 alperozturk96 force-pushed the fix/file-upload-worker-better-error-handling branch 2 times, most recently from 4c9b4e7 to a70d984 Compare June 19, 2026 10:28
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27820285987/artifacts/7747791649
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
fix(file-upload-worker): better error handling
9a93ec0 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	gradle/libs.versions.toml
@alperozturk96
fix(file-upload-worker): better error handling
7461b6a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
d112b8a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	gradle/libs.versions.toml
@alperozturk96
update lib
de36373 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/file-upload-worker-better-error-handling branch from a70d984 to de36373 Compare June 22, 2026 09:58
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3333
Correctness6767
Dodgy code211211
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3131
Performance4141
Security1616
Total409409

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27944655230/artifacts/7789455637
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 merged commit db2cffa into master Jun 22, 2026
20 of 23 checks passed
@alperozturk96 alperozturk96 deleted the fix/file-upload-worker-better-error-handling branch June 22, 2026 10:34
@backportbot backportbot Bot mentioned this pull request Jun 22, 2026
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 34.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @tobiasKaminsky