Handle user disabled exception as its own result code#1215

Open

tobiasKaminsky wants to merge 5 commits into

tobiasKaminsky commented Oct 10, 2023 •

edited

Loading

Member

If an user account is disabled, previously ResultCode was MAINTENANCE_MODE, now it is USER_DISABLED.
I will create a branch on Files app that is using this.

tobiasKaminsky added the 3. to review label

tobiasKaminsky requested review from ZetaTom and alperozturk96

October 10, 2023 07:47

ZetaTom previously approved these changes

View reviewed changes

alperozturk96 previously approved these changes

View reviewed changes

AndyScherzinger dismissed stale reviews from alperozturk96 and ZetaTom via

29df43f

November 10, 2023 08:50

AndyScherzinger force-pushed the disabled branch from c30fb8e to 29df43f Compare

November 10, 2023 08:50

alperozturk96 previously approved these changes

View reviewed changes

tobiasKaminsky dismissed alperozturk96’s stale review via

acd94f3

November 20, 2023 09:29

tobiasKaminsky force-pushed the disabled branch from 29df43f to acd94f3 Compare

November 20, 2023 09:29

alperozturk96 previously approved these changes

View reviewed changes

tobiasKaminsky dismissed alperozturk96’s stale review via

fb2260e

November 20, 2023 12:39

tobiasKaminsky force-pushed the disabled branch from acd94f3 to fb2260e Compare

November 20, 2023 12:39

ZetaTom previously approved these changes

View reviewed changes

alperozturk96 previously approved these changes

View reviewed changes

alperozturk96 commented Dec 8, 2023

Contributor

/rebase

nextcloud-command force-pushed the disabled branch from fb2260e to 0681669 Compare

December 8, 2023 09:11

AndyScherzinger force-pushed the disabled branch from 0681669 to 17843e1 Compare

December 8, 2023 10:09

joshtrichards reviewed

View reviewed changes

library/src/main/java/com/owncloud/android/lib/common/operations/ExceptionParser.java Outdated

library/src/main/java/com/owncloud/android/lib/common/operations/ExceptionParser.java Outdated

AndyScherzinger force-pushed the disabled branch from 17843e1 to 9c4d46d Compare

February 3, 2024 19:14

github-actions Bot commented Feb 3, 2024

Contributor

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	27
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	162

SpotBugs increased!

AndyScherzinger force-pushed the disabled branch from 9c4d46d to 6e70857 Compare

February 12, 2024 22:07

github-actions Bot commented Feb 12, 2024

Contributor

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	27
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	162

SpotBugs increased!

alperozturk96 force-pushed the disabled branch from 6e70857 to 353b9f5 Compare

February 13, 2024 08:59

github-actions Bot commented Feb 13, 2024

Contributor

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	27
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	162

SpotBugs increased!

tobiasKaminsky added the client change required label

tobiasKaminsky dismissed stale reviews from alperozturk96 and ZetaTom via

December 16, 2024 12:30

tobiasKaminsky force-pushed the disabled branch from 353b9f5 to 2428067 Compare

December 16, 2024 12:30

github-actions Bot commented Dec 16, 2024

Contributor

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	27
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	162

SpotBugs increased!

tobiasKaminsky force-pushed the disabled branch from 2428067 to d46ecea Compare

December 16, 2024 15:27

tobiasKaminsky mentioned this pull request

Show "account is disabled" when account is disabled nextcloud/android#14187

Open

1 task

github-actions Bot commented Dec 16, 2024

Contributor

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	27
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	162

SpotBugs increased!

1 similar comment

github-actions Bot commented Dec 19, 2024

Contributor

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	27
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	162

SpotBugs increased!


          Handle user disabled exception as its own result code

71557b9

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

tobiasKaminsky force-pushed the disabled branch from d46ecea to 71557b9 Compare

December 20, 2024 09:33

github-actions Bot commented Dec 20, 2024

Contributor

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161


          disable bruteforce

e31414e

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

github-actions Bot commented Jan 14, 2025

Contributor

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161


          disable bruteforce

eb4c3bb

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

github-actions Bot commented Jan 14, 2025

Contributor

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161


          add user "disabled"

7a08d74

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

github-actions Bot commented Jan 14, 2025

Contributor

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161


          test ony with NC31+

da3cc4d

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

github-actions Bot commented Jan 14, 2025

Contributor

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

codecov Bot commented Jan 14, 2025 •

edited

Loading

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...d/lib/common/operations/RemoteOperationResult.java	0.00%	5 Missing ⚠️
...android/lib/common/operations/ExceptionParser.java	0.00%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

joshtrichards reviewed

View reviewed changes

library/src/main/java/com/owncloud/android/lib/common/operations/ExceptionParser.java

                   private static final String INVALID_PATH_EXCEPTION_STRING = "OC\\Connector\\Sabre\\Exception\\InvalidPath";
                   private static final String INVALID_PATH_EXCEPTION_UPLOAD_STRING = "OCP\\Files\\InvalidPathException";
                   private static final String VIRUS_EXCEPTION_STRING = "OCA\\DAV\\Connector\\Sabre\\Exception\\UnsupportedMediaType";
+                  private static final String USER_DISABLED_MESSAGE = "OC\\User\\LoginException: Account disabled";

joshtrichards Mar 29, 2025

Member

I don't think we can include the 'Account disabled` part since it gets translated on the backend:

https://github.com/nextcloud/server/blob/57c71f8b9b34eb2af2914d11a9a6993ddf8deedf/lib/private/legacy/OC_User.php#L159

https://github.com/nextcloud/server/blob/57c71f8b9b34eb2af2914d11a9a6993ddf8deedf/lib/private/User/Session.php#L321

joshtrichards reviewed

View reviewed changes

joshtrichards left a comment

Member

If we make this more generic (for all LoginException's) we could also maybe cover other scenarios we're apprently not handling well like:

"message": "OC\\User\\LoginException: Password is expired, please use forgot password method to reset" (#8697)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review client change required