Simplify doc building with more refleak#14045
Merged
Merged
Conversation
drammock
approved these changes
Jul 10, 2026
Member
Author
|
Will fail until scikit-learn/scikit-learn#34458 is fixed, too. |
4 tasks
…letes in brain_gc [circle full]
Same mechanism as the brain_gc fix: pyvistaqt >= 0.11.3 deletes plotter windows via deleteLater on close, and processEvents alone never dispatches DeferredDelete events, so closed windows still counted as top-level widgets at the teardown check. Drain symmetrically in setup as well so a pending deletion from an earlier test does not inflate n_before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
larsoner
added a commit
to larsoner/pyvistaqt
that referenced
this pull request
Jul 12, 2026
The previous fix pushed window_size into the VTK render window unconditionally, which broke MNE's Brain sizing (CI on mne-tools/mne-python#14045): _window_ensure_minimum_sizes deliberately sizes the *interactor* to the requested size and grows the window around it, then reasserts window_size with the (larger) window size -- the unconditional push clobbered VTK's size after resizeGL had synced it, so screenshots came out at the wrong dimensions. Once the widget is realized, resizeGL owns the VTK size; the setter now only seeds it (for pre-show image/screenshot APIs) while _ctx is None. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Jul 14, 2026
* upstream/main: Make scrollbar handlers draggable (mne-tools#14040) [pre-commit.ci] pre-commit autoupdate (mne-tools#14052) Warn when Epochs events fall outside the raw data range (mne-tools#12989) (mne-tools#14004) Ensure epochs being concatenated have compatible event ids (mne-tools#14051) Widen main content area (mne-tools#14015) MAINT: remove dead gain/bits/value_range fields from _read_header in … (mne-tools#14047) ENH: replace `_get_blocks` binary reader with mffpy Reader API (mne-tools#14043) MAINT: Update dependency specifiers (mne-tools#14048) [dependabot]: Bump the actions group with 2 updates (mne-tools#14049) Simplify doc building with more refleak (mne-tools#14045) ENH: add overlay Brain GUI (mne-tools#14031) ENH: support multiple simultaneous overlays in Brain.add_data (mne-tools#13995) Add option to show a zero line in browser (mne-tools#14018) FIX: pass cmap name string not tuple to interactive topomap slider kwargs (mne-tools#14039) Doc/add ai policy pointer (mne-tools#14037) Allow subclasses of FigureClass to be passed to plot_raw/plot_epochs (mne-tools#13979) MAINT: Replace manual PNS binary block reader in `_read_segment_file` with `mffpy` (mne-tools#14030)
larsoner
added a commit
to sharifhsn/mne-python
that referenced
this pull request
Jul 14, 2026
* upstream/main: (206 commits) Improve type checks (mne-tools#14036) Make scrollbar handlers draggable (mne-tools#14040) [pre-commit.ci] pre-commit autoupdate (mne-tools#14052) Warn when Epochs events fall outside the raw data range (mne-tools#12989) (mne-tools#14004) Ensure epochs being concatenated have compatible event ids (mne-tools#14051) Widen main content area (mne-tools#14015) MAINT: remove dead gain/bits/value_range fields from _read_header in … (mne-tools#14047) ENH: replace `_get_blocks` binary reader with mffpy Reader API (mne-tools#14043) MAINT: Update dependency specifiers (mne-tools#14048) [dependabot]: Bump the actions group with 2 updates (mne-tools#14049) Simplify doc building with more refleak (mne-tools#14045) ENH: add overlay Brain GUI (mne-tools#14031) ENH: support multiple simultaneous overlays in Brain.add_data (mne-tools#13995) Add option to show a zero line in browser (mne-tools#14018) FIX: pass cmap name string not tuple to interactive topomap slider kwargs (mne-tools#14039) Doc/add ai policy pointer (mne-tools#14037) Allow subclasses of FigureClass to be passed to plot_raw/plot_epochs (mne-tools#13979) MAINT: Replace manual PNS binary block reader in `_read_segment_file` with `mffpy` (mne-tools#14030) Fix transition bandwidth reported in 'filter too short' error (mne-tools#11406) (mne-tools#14005) ENH: Show the current time as a vertical line in plot_evoked_topo (mne-tools#14032) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refleak0.2.1+ has a class that stores-and-checks now. Let's use it in the doc building and test steps.Leaving as draft until
Closes #14046