ENH: Add TimeChange behaviour to plot_evoked#14025
Open
Gnefil wants to merge 14 commits into
Open
Conversation
6 tasks
Gnefil
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adds TimeChange UI-event integration to mne.viz.plot_evoked() (and therefore Evoked.plot()), enabling evoked plots to both publish time changes on click and react to externally-published time changes by updating a vertical time marker.
Changes:
- Publish
TimeChangeevents from evoked butterfly plots on mouse click. - Subscribe evoked plots to
time_changeevents and move/update a vertical selection marker accordingly. - Add/extend tests to cover click-driven time selection and
TimeChangeevent handling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mne/viz/evoked.py | Publishes and subscribes to TimeChange events; adds time-marker updates in evoked plots. |
| mne/viz/tests/test_evoked.py | Adds tests ensuring click selection creates a marker and TimeChange updates it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Implements #14024.
What does this implement/fix?
Adds
TimeChangebehaviour inmne.viz.plot_evoked(), which is the underlying function formne.Evoked.plot()too.Additional information