Inline simple attachments for Copilot SDK#321518
Closed
dmitrivMS wants to merge 1 commit into
Closed
Conversation
dmitrivMS
added
the
agent-host
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #320612 by changing how Copilot SDK “Simple” attachments (those carrying modelRepresentation, e.g. pasted code blocks/feedback text) are sent: instead of being transmitted as opaque SDK blob attachments, they’re appended directly to the prompt so the model receives the content inline.
Changes:
- Inline
Simpleattachments withmodelRepresentationinto the outgoingpromptinCopilotAgentSession.send. - Only forward non-simple (or non-inlineable) attachments through the Copilot SDK
attachmentsfield. - Update the Copilot agent session unit test to expect the new prompt shape (and no SDK attachments) for simple attachments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts | Inlines Simple attachment modelRepresentation text into the prompt and stops converting it to SDK blob attachments. |
| src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts | Updates expectations to validate prompt inlining behavior for simple attachments. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Contributor
Author
|
Not needed - CLI regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320612