Skip to content

Fix "open changes in diff editor"#321423

Open
alexr00 wants to merge 1 commit into
mainfrom
alexr00/straight-wildfowl
Open

Fix "open changes in diff editor"#321423
alexr00 wants to merge 1 commit into
mainfrom
alexr00/straight-wildfowl

Conversation

@alexr00

@alexr00 alexr00 commented Jun 15, 2026

Copy link
Copy Markdown
Member

Fixes #314685

@alexr00 alexr00 requested review from Copilot and lszomoru June 15, 2026 14:54
@alexr00 alexr00 enabled auto-merge (squash) June 15, 2026 14:54
@alexr00 alexr00 self-assigned this Jun 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Chat’s “Open Changes in Diff Editor” action so it works even when the currently active editor is a webview (e.g. GHPR description), by ensuring the action opens the target file’s editor pane before toggling the diff UI.

Changes:

  • Stop using editorService.activeEditorPane as the target pane for diff toggling.
  • Always openEditor({ resource: uri }) for the file being acted on, ensuring getEditorIntegration(...) operates on the correct editor type.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingActions.ts Ensures “Open Changes in Diff Editor” opens the target file editor pane (not an unrelated active webview) before toggling diff.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chat's "Open Changes in Diff Editor" doesn't work when the active editor is a webview

2 participants