Fix "open changes in diff editor"#321423
Open
alexr00 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Chat’s “Open Changes in Diff Editor” action so it works even when the currently active editor is a webview (e.g. GHPR description), by ensuring the action opens the target file’s editor pane before toggling the diff UI.
Changes:
- Stop using
editorService.activeEditorPaneas the target pane for diff toggling. - Always
openEditor({ resource: uri })for the file being acted on, ensuringgetEditorIntegration(...)operates on the correct editor type.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingActions.ts |
Ensures “Open Changes in Diff Editor” opens the target file editor pane (not an unrelated active webview) before toggling diff. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #314685