chore: test simulation cache with native sqlite#321407
Closed
deepak1556 wants to merge 5 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Copilot simulation test cache implementation to stop relying on native sqlite3 via keyv/@keyv/sqlite, and instead use Node’s built-in node:sqlite APIs. This reduces native dependency surface area for the test harness while keeping existing committed cache DBs usable.
Changes:
- Replace
keyv/@keyv/sqliteusage in the simulation cache with a minimalnode:sqlite-backed key/value store. - Remove
keyvand@keyv/sqlitefromextensions/copilotdependencies and re-resolve the lockfile. - Update cache-layer enumeration logic to work with the new store.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| extensions/copilot/test/base/cache.ts | Introduces a minimal node:sqlite store and swaps the simulation cache over from keyv. |
| extensions/copilot/package.json | Drops keyv and @keyv/sqlite dependencies (and related overrides). |
| extensions/copilot/package-lock.json | Removes the transitive native sqlite dependency tree and updates lock metadata. |
Files not reviewed (1)
- extensions/copilot/package-lock.json: Generated file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.