Skip to content

Fix: omit untitled session in sessions list#321402

Merged
chrmarti merged 1 commit into
release/1.125from
chrmarti/scrawny-zebra
Jun 15, 2026
Merged

Fix: omit untitled session in sessions list#321402
chrmarti merged 1 commit into
release/1.125from
chrmarti/scrawny-zebra

Conversation

@chrmarti

@chrmarti chrmarti commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Copilot AI review requested due to automatic review settings June 15, 2026 13:12
@chrmarti chrmarti self-assigned this Jun 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the agent-host session listing overlay logic so that “provisional” (not-yet-materialized) sessions don’t leak into the sessions list while still idle, addressing the “untitled session shows up” scenario described by the PR title. It also adds targeted regression coverage and introduces CI “stability” reruns for the Agents Window smoke tests.

Changes:

  • Refines the listSessions() overlay source to exclude idle provisional sessions from the overlayed session summaries.
  • Adds a regression test for provisional-session visibility behavior during an active turn.
  • Adds CI steps that rerun the Agents Window smoke tests 20× on multiple platforms.
Show a summary per file
File Description
src/vs/platform/agentHost/test/node/agentService.test.ts Updates overlay-summary accessor usage and adds a new regression test for provisional session listing.
src/vs/platform/agentHost/node/agentService.ts Switches overlay logic to use the new filtered overlay-summary accessor and documents the rationale.
src/vs/platform/agentHost/node/agentHostStateManager.ts Replaces the “all summaries” accessor with a filtered overlay accessor intended to suppress idle provisional sessions.
build/azure-pipelines/win32/steps/product-build-win32-test.yml Adds a “run Agents Window smoke tests 20×” stability step (Windows).
build/azure-pipelines/linux/steps/product-build-linux-test.yml Adds a “run Agents Window smoke tests 20×” stability step (Linux).
build/azure-pipelines/darwin/steps/product-build-darwin-test.yml Adds a “run Agents Window smoke tests 20×” stability step (macOS).
.github/workflows/pr-win32-test.yml Adds a “run Agents Window smoke tests 20×” stability step (Windows PR workflow).
.github/workflows/pr-linux-test.yml Adds a “run Agents Window smoke tests 20×” stability step (Linux PR workflow).

Copilot's findings

  • Files reviewed: 8/8 changed files
  • Comments generated: 7

Comment thread src/vs/platform/agentHost/node/agentHostStateManager.ts Outdated
Comment thread src/vs/platform/agentHost/test/node/agentService.test.ts
Comment thread build/azure-pipelines/win32/steps/product-build-win32-test.yml Outdated
Comment thread build/azure-pipelines/linux/steps/product-build-linux-test.yml Outdated
Comment thread build/azure-pipelines/darwin/steps/product-build-darwin-test.yml Outdated
Comment thread .github/workflows/pr-win32-test.yml Outdated
Comment thread .github/workflows/pr-linux-test.yml Outdated
@chrmarti chrmarti force-pushed the chrmarti/scrawny-zebra branch from d709722 to 457c7ed Compare June 15, 2026 16:51
@chrmarti chrmarti marked this pull request as ready for review June 15, 2026 16:53
@chrmarti chrmarti force-pushed the chrmarti/scrawny-zebra branch from 457c7ed to 3b7f5d6 Compare June 15, 2026 17:21
@chrmarti chrmarti changed the base branch from main to release/1.125 June 15, 2026 17:22
@chrmarti chrmarti closed this Jun 15, 2026
@chrmarti chrmarti reopened this Jun 15, 2026
@chrmarti chrmarti enabled auto-merge (squash) June 15, 2026 20:01
@chrmarti chrmarti merged commit 4d74ce9 into release/1.125 Jun 15, 2026
43 of 48 checks passed
@chrmarti chrmarti deleted the chrmarti/scrawny-zebra branch June 15, 2026 20:33
@vs-code-engineering vs-code-engineering Bot added this to the 1.125.0 milestone Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants