Skip to content

remove hardcoded nodejs mirror#321400

Open
joaomoreno wants to merge 1 commit into
mainfrom
joao/olive-emu
Open

remove hardcoded nodejs mirror#321400
joaomoreno wants to merge 1 commit into
mainfrom
joao/olive-emu

Conversation

@joaomoreno

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings June 15, 2026 13:05
@joaomoreno joaomoreno enabled auto-merge (squash) June 15, 2026 13:05
@joaomoreno joaomoreno self-assigned this Jun 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the hardcoded Node.js mirror URL from the Copilot simulation fixture that models the VS Code Linux product build pipeline, aligning the fixture with a default NodeTool configuration.

Changes:

  • Removed nodejsMirror from the NodeTool@0 step in the Linux build YAML fixture.
  • Minor fixture line reflow due to the removed line (shifts subsequent line numbers).
Show a summary per file
File Description
extensions/copilot/test/simulation/fixtures/codeMapper/product-build-linux.yml Drops the hardcoded nodejsMirror input from the NodeTool task in the YAML fixture used by code mapper simulation tests.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment on lines 27 to 31
- task: NodeTool@0
inputs:
versionSource: fromFile
versionFilePath: .nvmrc
nodejsMirror: https://github.com/joaomoreno/node-mirror/releases/download

@deepak1556 deepak1556 disabled auto-merge June 15, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants