ci: restore chat pipeline to windows-latest#321364
Draft
deepak1556 wants to merge 7 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the Copilot/chat CI coverage on GitHub-hosted Windows by switching workflows back to windows-latest, while aligning Node selection with the repo’s .nvmrc to avoid hardcoded Node pins.
Changes:
- Switched Windows CI from
windows-2022back towindows-latest. - Replaced explicit Node version pins with
node-version-fileto use the repo/extension.nvmrc.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extensions/copilot/.github/workflows/pr.yml | Moves Copilot PR Windows tests back to windows-latest and uses .nvmrc for Node setup. |
| .github/workflows/chat-lib-package.yml | Restores chat-lib test matrix to windows-latest and uses extensions/copilot/.nvmrc for Node setup. |
deepak1556
force-pushed
the
robo/fix_windows_ci_chat
branch
2 times, most recently
from
73a3154 to
24ed69a
Compare
The module locks the node-gyp dependency to 8.x due to its transitive sqlite3 native module dependency this in turn blocks using newer windows CI, refs #321267 The module can be replaced with built-in sqlite support from Node.js without losing the on-disk cache format has already been committed.
deepak1556
force-pushed
the
robo/fix_windows_ci_chat
branch
from
24ed69a to
2e1a42c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321267
Node v24.x ships with npm v11.x which already has node-gyp > v12.x