fix: align the pre-commit black hook with the formatting CI enforces#2303
Open
vignesh-nagarajan-vn wants to merge 1 commit into
Open
fix: align the pre-commit black hook with the formatting CI enforces#2303vignesh-nagarajan-vn wants to merge 1 commit into
vignesh-nagarajan-vn wants to merge 1 commit into
Conversation
The pre-commit config pinned black 23.7.0, whose style disagrees with the black that CI runs (`make black`, unpinned latest): on a clean checkout it reformats qlib/model/riskmodel/shrink.py - a file the committer never touched - so the documented dev setup (`pre-commit install`, docs/developer/code_standard_and_dev_guide.rst) makes any commit fail or mutate unrelated files. Pin 24.8.0 instead: verified to leave all 336 repo files unchanged (it agrees with CI's current black on this codebase) while still supporting Python 3.8, qlib's documented floor. The flake8 pin is left untouched - no misbehavior observed there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI checks formatting with the latest black (make black), but the
pre-commit config pinned black 23.7.0. The two disagree on
qlib/model/riskmodel/shrink.py, so on a clean checkout the documented
dev setup (pre-commit install) reformats a file the committer never
touched - the very first commit fails the hook or mutates unrelated
code.
all 336 repo files and still supports Python 3.8, qlib's floor.
silently again.