Skip to content

Fix image saving in HelloDrone#4658

Open
webshared wants to merge 1 commit into
microsoft:mainfrom
webshared:main
Open

Fix image saving in HelloDrone#4658
webshared wants to merge 1 commit into
microsoft:mainfrom
webshared:main

Conversation

@webshared

Copy link
Copy Markdown

Fixes: #HelloDrone never asked to save image.

About

Fixed HelloDrone/main.cpp code to ask for path and save images. There was a simple bug.

How Has This Been Tested?

Run locally with AirSim, images saved as expected.

Screenshots (if appropriate):

After the fix applied:

 % ./main 
Waiting for connection - X

Connected!

Client Ver:1 (Min Req:1), Server Ver:1 (Min Req:1)
Press Enter to get FPV image
# of images received: 2
Enter path with ending separator to save images (leave empty for no save)
./img/
Image uint8 size: 62355
Image float size: 0
Image uint8 size: 0
Image float size: 36864
Press Enter to arm the drone

@xxEoD2242

Copy link
Copy Markdown

Hey @atolkachiov, with the Open Source AirSim project being shutdown, no new features will be integrated. Would you like me to add this to a fork I created to continue development of the open source project? You can find it here: Colosseum (AirSim successor)

@webshared

Copy link
Copy Markdown
Author

Hey @atolkachiov, with the Open Source AirSim project being shutdown, no new features will be integrated. Would you like me to add this to a fork I created to continue development of the open source project? You can find it here: Colosseum (AirSim successor)

Hey @xxEoD2242, sure pls merge into Colosseum, it has the same issue as I see.

@xxEoD2242

Copy link
Copy Markdown

Hey @atolkachiov, with the Open Source AirSim project being shutdown, no new features will be integrated. Would you like me to add this to a fork I created to continue development of the open source project? You can find it here: Colosseum (AirSim successor)

Hey @xxEoD2242, sure pls merge into Colosseum, it has the same issue as I see.

Done -> Colosseum PR #2

Bartok9 added a commit to Bartok9/AirSim that referenced this pull request Jul 16, 2026
Invert empty-check so HelloDrone asks for a save path when
simGetImages actually returned frames (not when the vector is empty).

Salvage of microsoft#4658 by @webshared — rebased onto
current main and re-verified (CRLF preserved).

Spec: tools/aerial-drone-pr-campaign/specs/airsim/2026-07-16-salvage.md
@Bartok9

Bartok9 commented Jul 16, 2026

Copy link
Copy Markdown

Friendly note: opened a rebased salvage of this one-liner on current main as #9784 (credit @webshared). Happy to close mine if you prefer to refresh this PR instead — just full credit either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants