umqtt.simple: Added call to main() function in example scripts#199
Merged
dpgeorge merged 1 commit intoJul 1, 2026
Merged
Conversation
Member
|
The example_sub.py and example_pub.py scripts do have this call to main(), but not the example_sub_led.py and example_pub_button.py scripts. So the latter pair either stay as they are, or both should have main() added to the end like is done here. |
Author
|
@dpgeorge No problem, I have added an additional commit adding the call to example_pub_button.py too. |
spynappels
changed the title
Contributor
dpgeorge
approved these changes
Jul 1, 2026
dpgeorge
left a comment
dpgeorge
left a comment
Member
There was a problem hiding this comment.
Thanks for updating, and sorry this took forever to get back to.
This change looks fine, it makes all the examples consistent in calling main().
Added call to `main()` function at end of script after the function definition. Matches other example scripts in `umqtt.simple` lib. Signed-off-by: Damien George <damien@micropython.org>
dpgeorge
force-pushed
the
fix_umqtt.simple_example_sub_led.py
branch
from
18cc5d6 to
1852c01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added call to main() function at end of script after the function definition. Matches other example scripts in umqtt.simple lib and is tested as functional on ESP8266 with MicroPython 1.9.1
Stefan