Pre-build msg packages with micro-ROS typesupport before full build#819
Closed
David-LP99 wants to merge 1 commit into
Closed
Pre-build msg packages with micro-ROS typesupport before full build#819David-LP99 wants to merge 1 commit into
David-LP99 wants to merge 1 commit into
Conversation
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The host build (
config/host/generic/build.sh) builds the micro-ROSXRCE-DDS typesupport generators (
rosidl_typesupport_microxrcedds_c/_cpp),sources them, then runs a single full-workspace
colcon build.builtin_interfaces,unique_identifier_msgs,service_msgs, andaction_msgsare pulled in implicitly by rosidl's action/service codeexpansion for many interface packages, but those dependent packages don't
declare them in
package.xml. As a result, colcon's normaldependency-ordered build can resolve these four packages from the system
/opt/ros/jazzyinstall instead of building them in the workspace.The system versions were built without
rosidl_typesupport_microxrcedds_cavailable (it's a micro-ROS-only generator, not part of stock ROS 2), so
they have no micro-ROS XRCE-DDS typesupport compiled in. Any package that
needs microxrcedds typesupport for these message types then fails to link.
Fix
builtin_interfaces,unique_identifier_msgs,service_msgs,action_msgs(in that dependency order) after themicroxrcedds typesupport generators are already on the path, so rosidl
regenerates and compiles the microxrcedds typesupport for them.
install/local_setup.bashafterward soCMAKE_PREFIX_PATHprefers these workspace-built versions over
/opt/ros/jazzyin thesubsequent full workspace build.
Testing
action/service interfaces.
install/typesupport libs for the fourpackages include microxrcedds symbols (not just the system ones).